Re: [PATCH -mm 0/2] RapidIO: Changes to handling of RIO switches

From: Micha Nelissen
Date: Mon Oct 25 2010 - 12:13:37 EST


Bounine, Alexandre wrote:
Micha Nelissen <micha@xxxxxxxxxxxxxx> wrote:
rid of rswitch->switchid and use component_tag directly for
switches).
I still prefer the destid as the single identification id.

In your patch you allocate individual destid for switches. This method
has two problems:
1. The destid for the switch needs an additional mechanism to share it
among processors in the RIO network,

? See comment for 2)

2. It takes ID value away from the pool of available IDs, what will

It does not take an ID away, it shares it with a connected endpoint to that switch. The tag uses one extra bit to identify the device as a switch instead of an endpoint. This provides the information to unambiguously identify a switch from an endpoint.

Micha
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/