Re: [PATCH 0/29] My patch queue for memorystick subsystem

From: Alex Dubov
Date: Mon Oct 25 2010 - 12:10:17 EST


>
> > Normally, functional
> > patches should precede the cosmetic one, so that the
> functionality can be
> > discussed first.
>
> More usually it's the other way around, actually: cleanups
> come first.
>
> Because the cleanups are usually uncontroversial, and
> because
> substantive changes against cleaner code are easier to
> review/understand and because the substantive changes are
> then easier
> to revert or fix.
>


My problem here is that out of 30 patches, 20 appear to be rewrites and
clean-ups of things not broken.

That's why I'd rather prefer to see actual functional changes first.




--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/