Re: [PATCH 19/29] memstick: jmb38x_ms: add register read/write functions

[Alex Dubov]

--- On Fri, 22/10/10, Maxim Levitsky <maximlevitsky@xxxxxxxxx> wrote:

> From: Maxim Levitsky <maximlevitsky@xxxxxxxxx>
> Subject: [PATCH 19/29] memstick: jmb38x_ms: add register read/write functions
> To: "Alex Dubov" <oakad@xxxxxxxxx>
> Cc: "Andrew Morton" <akpm@xxxxxxxxxxxxxxxxxxxx>, "LKML" <linux-kernel@xxxxxxxxxxxxxxx>, "Maxim Levitsky" <maximlevitsky@xxxxxxxxx>
> Received: Friday, 22 October, 2010, 4:53 PM
> All over the code it is a bit easier
> to see the
> register access with this patch. Also set/clear mask
> helpers refactor code a bit, but the biggest reason
> for this patch is to make it possible to trace register
> read/writes with a flip of a module param.
> 
> Currently these functions are unused, but will be by later
> code
> 
> Signed-off-by: Maxim Levitsky <maximlevitsky@xxxxxxxxx>

This looks like a case of:
1. You've run into a technical difficulty.
2. You used some temporary code to resolve and document it.
3. Now this temporary code is forever here to stay.




      
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/