Re: [PATCH 08/29] memstick: mspro: add comments to few functions

From: Alex Dubov
Date: Mon Oct 25 2010 - 11:18:53 EST


--- On Fri, 22/10/10, Maxim Levitsky <maximlevitsky@xxxxxxxxx> wrote:

> From: Maxim Levitsky <maximlevitsky@xxxxxxxxx>
> Subject: [PATCH 08/29] memstick: mspro: add comments to few functions
> To: "Alex Dubov" <oakad@xxxxxxxxx>
> Cc: "Andrew Morton" <akpm@xxxxxxxxxxxxxxxxxxxx>, "LKML" <linux-kernel@xxxxxxxxxxxxxxx>, "Maxim Levitsky" <maximlevitsky@xxxxxxxxx>
> Received: Friday, 22 October, 2010, 4:53 PM
> a comment before function is not only
> a good way
> to give some information to the reader, but
> it serves as a good anchor point for diff so that
> it doesn't produce a diff between different
> functions (sigh...)
>

Comments of new functions belong to the patch which introduces these new
functions. And those functions (as I already said) belong to the patch
which introduces new functionality, using these functions, desirably,
one function at a time.






--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/