Re: [PATCH] Partially revert patch that encloses asm-offset.h numbers in brackets

From: Jan Beulich
Date: Mon Oct 25 2010 - 11:05:33 EST


>>> On 25.10.10 at 16:54, David Howells <dhowells@xxxxxxxxxx> wrote:
> Jan Beulich <JBeulich@xxxxxxxxxx> wrote:
>
>> Isn't this a gas bug then? Anywhere you use a plain number you
>> should also be permitted to use an expression.
>
> Whoever defined the gas assembly syntax for binutils specified that (N) as
> an
> operand defines an absolute address and N defines an immediate value.
>
> However, prefixing an expression with a unary plus works for me, so adding
> this into my patch:
>
> - s:^->\([^ ]*\) [\$$#]*\([-0-9]*\) \(.*\):#define \1 \2 /* \3 */:; \
> + s:^->\([^ ]*\) [\$$#]*\([-0-9]*\) \(.*\):#define \1 +(\2) /* \3 */:; \
>
> Does that work for you?

Alexander, you seem to be having access to a worst case system -
could you give this a try?

Thanks, Jan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/