Re: [PATCH 03/29] memstick: core: add new functions

[Alex Dubov]

--- On Fri, 22/10/10, Maxim Levitsky <maximlevitsky@xxxxxxxxx> wrote:

> From: Maxim Levitsky <maximlevitsky@xxxxxxxxx>
> Subject: [PATCH 03/29] memstick: core: add new functions
> To: "Alex Dubov" <oakad@xxxxxxxxx>
> Cc: "Andrew Morton" <akpm@xxxxxxxxxxxxxxxxxxxx>, "LKML" <linux-kernel@xxxxxxxxxxxxxxx>, "Maxim Levitsky" <maximlevitsky@xxxxxxxxx>
> Received: Friday, 22 October, 2010, 4:53 PM
> Add a lot of support code that will
> be used later.
> 

You're adding here a lot of temporarily dead code, which, while being
useful, should be better added together with the actual driver
functionality.

Besides this, the patch has a lot of unneeded clean-ups which are better
be set as a separate patch.

And it doesn't conform to the coding guideline either (4 byte indents,
instead of tabs).



      
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/