Re: [PATCH 01/29] memstick: core: header cleanups

[Alex Dubov]

--- On Fri, 22/10/10, Maxim Levitsky <maximlevitsky@xxxxxxxxx> wrote:

> Received: Friday, 22 October, 2010, 4:53 PM
> * Replace the __attribute__((packed))
> with __packed

This introduces unnecessary noise and can be merged into a common clean-up
patch.

> * Add struct mspro_cmdex_argument, argument for
> MS_TPC_EX_SET_CMD
> * Increase size of inline buffer in memstick_request to 32
> because thats the size of registers and someone might need
> to read them
> all. That structure is allocated one per memstick host, so
> its size
> doesn't matter.

This functional changes are better be joined with the first patch which
actually requires them (these are just 4 lines).

> 
> * Add comments about few members of memstick_request

Belongs to the clean-up or a separate commenting patch.

> 
> Signed-off-by: Maxim Levitsky <maximlevitky@xxxxxxxxx>
> ---



      
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/