RE: [PATCH 1/2] block: cciss: fix information leak to userland

[Miller, Mike (OS Dev)]

> -----Original Message-----
> From: Vasiliy Kulikov [mailto:segooon@xxxxxxxxx] 
> Sent: Saturday, October 23, 2010 3:25 AM
> To: kernel-janitors@xxxxxxxxxxxxxxx
> Cc: Miller, Mike (OS Dev); Jens Axboe; Stephen M. Cameron; 
> Andrew Morton; ISS StorageDev; linux-kernel@xxxxxxxxxxxxxxx
> Subject: [PATCH 1/2] block: cciss: fix information leak to userland
> 
> Structure IOCTL_Command_struct is copied to userland with 
> some padding fields at the end of the struct unitialized.
> It leads to leaking of stack memory.
> 
> Signed-off-by: Vasiliy Kulikov <segooon@xxxxxxxxx>
> ---
>  drivers/block/cciss.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/block/cciss.c b/drivers/block/cciss.c 
> index 762a81a..cd08324 100644
> --- a/drivers/block/cciss.c
> +++ b/drivers/block/cciss.c
> @@ -1142,6 +1142,7 @@ static int 
> cciss_ioctl32_passthru(struct block_device *bdev, fmode_t mode,
>  	int err;
>  	u32 cp;
>  
> +	memset(&arg64, 0, sizeof(arg64));
>  	err = 0;
>  	err |=
>  	    copy_from_user(&arg64.LUN_info, &arg32->LUN_info,
> --

Acked-by: Mike Miller <mike.miller@xxxxxx>

> 1.7.0.4
> 
> --
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/