Re: [PATCH] kbuild: check return value of asprintf()

[Michal Marek]

(adding Randy to CC)

On 22.10.2010 16:32, Namhyung Kim wrote:
> Check return value of asprintf() in docsect() and exit if error
> occurs. This removes following warning:
> 
>   HOSTCC  scripts/basic/docproc
> scripts/basic/docproc.c: In function âdocsectâ:
> scripts/basic/docproc.c:336: warning: ignoring return value of âasprintfâ,
> 				declared with attribute warn_unused_result
> 
> Signed-off-by: Namhyung Kim <namhyung@xxxxxxxxx>
> ---
> The patch is on top of v2.6.36, thanks.
> 
>  scripts/basic/docproc.c |    5 ++++-
>  1 files changed, 4 insertions(+), 1 deletions(-)
> 
> diff --git a/scripts/basic/docproc.c b/scripts/basic/docproc.c
> index fc3b18d..98dec87 100644
> --- a/scripts/basic/docproc.c
> +++ b/scripts/basic/docproc.c
> @@ -333,7 +333,10 @@ static void docsect(char *filename, char *line)
>  		if (*s == '\n')
>  			*s = '\0';
>  
> -	asprintf(&s, "DOC: %s", line);
> +	if (asprintf(&s, "DOC: %s", line) < 0) {
> +		perror("asprintf");
> +		exit(1);
> +	}
>  	consume_symbol(s);
>  	free(s);
>  

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/