Re: [PATCH 10/15] x86, apic: Set fixmap only one time

From: Thomas Gleixner
Date: Sun Oct 24 2010 - 06:04:20 EST


On Sat, 23 Oct 2010, Yinghai Lu wrote:

> Check if mp_lapic_addr is assigned or not.

Why is it called twice in the first place ? Because you messed up that
other patch ?

> Signed-off-by: Yinghai Lu <yinghai@xxxxxxxxxx>
> ---
> arch/x86/kernel/apic/apic.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/arch/x86/kernel/apic/apic.c b/arch/x86/kernel/apic/apic.c
> index 3a4e770..2cfa622 100644
> --- a/arch/x86/kernel/apic/apic.c
> +++ b/arch/x86/kernel/apic/apic.c
> @@ -1682,6 +1682,9 @@ void __init init_apic_mappings(void)
>
> void __init smp_register_lapic_address(unsigned long address)
> {
> + if (mp_lapic_addr)
> + return;
> +
> mp_lapic_addr = address;
>
> set_fixmap_nocache(FIX_APIC_BASE, address);
> --
> 1.7.1
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/