Re: [PATCH -next] nfs: include ratelimit.h, fix nfs4state builderror

From: Trond Myklebust
Date: Sat Oct 23 2010 - 10:09:37 EST


On Fri, 2010-10-22 at 16:18 -0700, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@xxxxxxxxxx>
>
> nfs4state.c uses interfaces from ratelimit.h. It needs to include
> that header file to fix build errors:
>
> fs/nfs/nfs4state.c:1195: warning: type defaults to 'int' in declaration of 'DEFINE_RATELIMIT_STATE'
> fs/nfs/nfs4state.c:1195: warning: parameter names (without types) in function declaration
> fs/nfs/nfs4state.c:1195: error: invalid storage class for function 'DEFINE_RATELIMIT_STATE'
> fs/nfs/nfs4state.c:1195: error: implicit declaration of function '__ratelimit'
> fs/nfs/nfs4state.c:1195: error: '_rs' undeclared (first use in this function)
>
> Signed-off-by: Randy Dunlap <randy.dunlap@xxxxxxxxxx>
> Cc: Trond Myklebust <Trond.Myklebust@xxxxxxxxxx>
> Cc: linux-nfs@xxxxxxxxxxxxxxx
> ---
> fs/nfs/nfs4state.c | 1 +
> 1 file changed, 1 insertion(+)
>
> --- linux-next-20101022.orig/fs/nfs/nfs4state.c
> +++ linux-next-20101022/fs/nfs/nfs4state.c
> @@ -46,6 +46,7 @@
> #include <linux/kthread.h>
> #include <linux/module.h>
> #include <linux/random.h>
> +#include <linux/ratelimit.h>
> #include <linux/workqueue.h>
> #include <linux/bitops.h>
>

That one is my fault. Sorry, and thanks Randy! I've applied the fix to
the linux-next branch...

Cheers
Trond
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/