Re: [PATCH 1/5] cciss: remove controllers supported by hpsa

From: Bruno PrÃmont
Date: Fri Oct 22 2010 - 15:48:07 EST


On Fri, 22 October 2010 "Stephen M. Cameron" wrote:
> From: Stephen M. Cameron <scameron@xxxxxxxxxxxxxxxxxx>
>
> We would prefer not to have any overlap between the two drivers.
> Remove the cciss_allow_hpsa option, as it it is no longer needed.
>
> Signed-off-by: Stephen M. Cameron <scameron@xxxxxxxxxxxxxxxxxx>

I think it would be helpful to provide clear indication in cciss'
Kconfig description about which controllers are the last ones to be
supported by cciss and starting from which ones hpsa is needed.

In addition the dev_warn before returning -ENODEV could include a
hint that newish controllers need hpsa driver instead of just saying
"unrecognized board ...", this at least when hpsa driver was not
included in kernel build.

Regards,
Bruno
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/