Re: [PATCH] Make div64_u64() precise on 32bit platforms

From: Oleg Nesterov
Date: Thu Oct 21 2010 - 14:17:00 EST


Andrew, please drop

lib-div64c-document-that-div64_u64-is-not-precise-on-32bit-platforms.patch

On 10/21, Brian Behlendorf wrote:
>
> I think we should use your simpler version. There's no good reason to
> make this more complicated than it needs to be. I haven't been able to
> find a test case where your changes get the wrong result.

Great!

> From: Brian Behlendorf <behlendorf1@xxxxxxxx>
> Date: Thu, 5 Aug 2010 14:59:11 -0700
> Subject: [PATCH] Fix div64_u64 for 32bit platforms
>
> The current implementation of div64_u64 for 32bit systems returns
> an approximately correct result when the divisor exceeds 32bits.
> Since doing 64bit division using 32bit hardware is a long since
> solved problem we just use one of the existing proven methods.

Brian, you forgot to add your sob. Hopefully Andrew can add

Signed-off-by: Brian Behlendorf <behlendorf1@xxxxxxxx>

Signed-off-by: Oleg Nesterov <oleg@xxxxxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/