Re: [B.A.T.M.A.N.] [resend][PATCHv2] staging: batman-adv: removeuseless addr_to_string()

From: Sven Eckelmann
Date: Wed Oct 20 2010 - 18:16:49 EST


On Wed, Oct 20, 2010 at 01:57:49PM -0700, Greg KH wrote:
> On Wed, Oct 20, 2010 at 10:51:15PM +0200, Sven Eckelmann wrote:
> > On Wed, Oct 20, 2010 at 06:47:44PM +0300, Andy Shevchenko wrote:
> > > Since all *printf() methods in the kernel understand '%pM' modifier the
> > > conversion to the string is useless beforehand.
> > >
> > > Additionally this patch decreases batman_if structure by 20 bytes.
> >
> > Thanks for your patch. I have problems with compiling due to other patches in
> > the queue. I will fix that and recommend it as patch for 2.6.38.
>
> What do you mean by this? It applies just fine to my tree, so why can't
> I take it now?

If you want then do so, but the stuff in batman-adv's master must be fixed so
they have to apply the v3 version of the patch and not the v2 version Andy
sent.

Best regards,
Sven

Attachment: signature.asc
Description: Digital signature