Re: kfifo must_check warning (+ patch)

From: Alan Cox
Date: Wed Oct 20 2010 - 14:38:57 EST


> Some versions of gcc mysteriously report:
> drivers/char/n_gsm.c:1580: warning: ignoring return value of '__kfifo_must_check_helper', declared with attribute warn_unused_result
>
> This warning can be eliminated by using a local variable for the
> returned result value, as suggested by Andrew Morton.

But that just hides the bug in the helper surely - the helper has type
errors so needs fixing - not this. If you apply this then the underlying
bug is just going to get forgotten

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/