RE: [PATCH 1/2] drivers:staging:ti-st: move TI_ST from staging

From: Savoy, Pavan
Date: Wed Oct 20 2010 - 12:04:43 EST




> -----Original Message-----
> From: Andrew Morton [mailto:akpm@xxxxxxxxxxxxxxxxxxxx]
> Sent: Wednesday, October 20, 2010 12:22 AM
> To: Savoy, Pavan
> Cc: gregkh@xxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; alan@xxxxxxxxxxxxxxxxxxx;
> devel@xxxxxxxxxxxxxxxxxxxx
> Subject: Re: [PATCH 1/2] drivers:staging:ti-st: move TI_ST from staging
>
> On Wed, 6 Oct 2010 12:18:14 -0400 pavan_savoy@xxxxxx wrote:
>
> > +/**
> > + * st_reg_complete -
> > + * to call registration complete callbacks
> > + * of all protocol stack drivers
> > + */
> > +void st_reg_complete(struct st_data_s *st_gdata, char err)
>
> The driver has a lot of "kerneldoc" comments which are incomplete -
> they don't document the arguments.

For functions too?
Sure Andrew, I will post a patch to comment the arguments soon.

Thanks for the comments.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/