Re: [PATCH v2 3/3] drivers: cleanup Kconfig stuff

[Felipe Balbi]

On Wed, Oct 20, 2010 at 02:46:49AM -0500, Roger Quadros wrote:
> On 10/19/2010 05:33 PM, ext Felipe Contreras wrote:
> > Hi Roger,
> >
> > On Tue, Oct 19, 2010 at 4:40 PM, Roger Quadros<roger.quadros@xxxxxxxxx>  wrote:
> > > > @@ -843,6 +841,7 @@ config USB_CDC_COMPOSITE
> > > >   config USB_G_NOKIA
> > > >         tristate "Nokia composite gadget"
> > > >         depends on PHONET
> > > > +       depends on USB_GADGET_MUSB_HDRC
> > >
> > > This is wrong. Is there a build problem or run-time problem without this?
> >
> > Try:
> > CONFIG_USB_G_NOKIA=y
> > CONFIG_USB_GADGET_MUSB_HDRC=n
> >
> > At least g_nokia doesn't seem to work correctly on my N900.
> It won't work on N900 because N900 has MUSB USB gadget controller and
> it needs to be selected somehow while building for N900.
>
> You should set CONFIG_USB_GADGET_MUSB_HDRC to y somewhere else while
> building for N900 and not here because g_nokia is not MUSB specific.

It's the same thing I've been trying to say. No gadget driver is
controller-specific. Even though this one is called g_nokia.ko it
doesn't only Nokia can use it, neither does it mean nokia will always
use MUSB.

--
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/