Re: [PATCH] kernel: printk: Fix a coding style issue.

[Andrew Morton]

On Tue, 19 Oct 2010 20:19:01 +0200
Ralf Thielow <ralf.thielow@xxxxxxxxxxxxxx> wrote:

> Fixed a coding style issue of "do_syslog" in
> case of open or close the log.
> 
> Signed-off-by: Ralf Thielow <ralf.thielow@xxxxxxxxxxxxxx>
> ---
>  kernel/printk.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/kernel/printk.c b/kernel/printk.c
> index 8fe465a..3539744 100644
> --- a/kernel/printk.c
> +++ b/kernel/printk.c
> @@ -273,9 +273,8 @@ int do_syslog(int type, char __user *buf, int len, bool from_file)
>  		return error;
>  
>  	switch (type) {
> -	case SYSLOG_ACTION_CLOSE:	/* Close log */
> -		break;
>  	case SYSLOG_ACTION_OPEN:	/* Open log */
> +	case SYSLOG_ACTION_CLOSE:	/* Close log */
>  		break;
>  	case SYSLOG_ACTION_READ:	/* Read from log */
>  		error = -EINVAL;

I don't really think that the code needed fixing there?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/