Re: ima: use of radix tree cache indexing == massive waste of memory?

From: H. Peter Anvin
Date: Mon Oct 18 2010 - 14:08:31 EST


On 10/18/2010 09:48 AM, Eric Paris wrote:
>
> 1) IMA uses radix trees which end up wasting 500 bytes per inode because
> the key is too sparse. I've got a patch which uses an rbtree instead
> I'm testing and will send along shortly. I found it funny working on
> the patch to see that Documentation/rbtree.txt says "This differs from
> radix trees (which are used to efficiently store sparse arrays and thus
> use long integer indexes to insert/access/delete nodes)" Which flys in
> the face of this report.
>

Radix trees can efficiently store data associated with sparse keys *as
long as the keys are clustered*. For random key distributions, they
perform horribly.

-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/