Re: [Patch] Limit sysctl_tcp_mem and sysctl_udp_mem initializersto prevent integer overflows.

From: Eric Dumazet
Date: Mon Oct 18 2010 - 13:52:39 EST


Le lundi 18 octobre 2010 Ã 12:43 -0500, Robin Holt a Ãcrit :
> On Tue, Oct 05, 2010 at 02:50:32PM -0700, David Miller wrote:
> > From: Robin Holt <holt@xxxxxxx>
> > Date: Sat, 02 Oct 2010 06:24:06 -0500
> >
> > > Subject: [Patch] Limit sysctl_tcp_mem and sysctl_udp_mem initializers to prevent integer overflows.
> > >
> > > On a 16TB x86_64 machine, sysctl_tcp_mem[2], sysctl_udp_mem[2], and
> > > sysctl_sctp_mem[2] can integer overflow. Set limit such that they are
> > > maximized without overflowing.
> > >
> > > Signed-off-by: Robin Holt <holt@xxxxxxx>
> >
> > Robin please resubmit this with the SCTP bits included.
>
> David,
>
> I did not mean to blow you off. I was not going to resubmit because
> Eric's patch is the preferred direction. I had been given an indication
> that my patch was preferred, but that indicator changed.
>

Maybe there is some misunderstanding.

My patch was for net-next kernels (not before 2.6.37), while yours was
applicable to previous kernels.



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/