Re: [PATCH] checkpatch: allow single space before labels

From: Ted Ts'o
Date: Mon Oct 18 2010 - 10:53:50 EST


On Mon, Oct 18, 2010 at 10:39:35AM -0400, Ted Ts'o wrote:
> On Sun, Oct 17, 2010 at 04:26:25PM -0400, Mike Frysinger wrote:
> > On Sun, Oct 17, 2010 at 16:01, Peter Zijlstra wrote:
> > > On Sun, 2010-10-17 at 15:49 -0400, Mike Frysinger wrote:
> > >> sounds like a good reason to shut up the new unintended warnings
> > >
> > > I'm failing to see any logic there, old code doesn't generate warnings,
> > > its new code that would, and new code should never have any whitespace
> > > in front of labels.
> >
> > it's a waste of time to massage code to one person's opinion
>
> +1
>
> It's not in CondingStyle; I prefer to outdent labels by one tab stop:

Note that there is absolutely nothing about how labels should be
indented in CodingStyle at all, and I very much resist code
straightjackets being imposed by checkpatch.pl implementors.

Can we please stop this nonsense?

- Ted

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/