Re: [PATCH 11/22] ext3: use little endian bitops

From: Jan Kara
Date: Mon Oct 18 2010 - 06:33:04 EST


On Fri 15-10-10 18:46:10, Akinobu Mita wrote:
> As a preparation for removing ext2 non-atomic bit operations from
> asm/bitops.h. This converts ext2 non-atomic bit operations to
> little endian bit operations.
>
> Signed-off-by: Akinobu Mita <akinobu.mita@xxxxxxxxx>
> Cc: Jan Kara <jack@xxxxxxx>
> Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> Cc: Andreas Dilger <adilger.kernel@xxxxxxxxx>
> Cc: linux-ext4@xxxxxxxxxxxxxxx
Acked-by: Jan Kara <jack@xxxxxxx>

Honza
> ---
> include/linux/ext3_fs.h | 15 ++++++++++-----
> 1 files changed, 10 insertions(+), 5 deletions(-)
>
> diff --git a/include/linux/ext3_fs.h b/include/linux/ext3_fs.h
> index 6ce1bca..34ef455 100644
> --- a/include/linux/ext3_fs.h
> +++ b/include/linux/ext3_fs.h
> @@ -418,13 +418,18 @@ struct ext3_inode {
> #define EXT2_MOUNT_DATA_FLAGS EXT3_MOUNT_DATA_FLAGS
> #endif
>
> -#define ext3_set_bit ext2_set_bit
> +#define ext3_set_bit(nr, addr) \
> + __test_and_set_le_bit((nr), (unsigned long *)(addr))
> #define ext3_set_bit_atomic ext2_set_bit_atomic
> -#define ext3_clear_bit ext2_clear_bit
> +#define ext3_clear_bit(nr, addr) \
> + __test_and_clear_le_bit((nr), (unsigned long *)(addr))
> #define ext3_clear_bit_atomic ext2_clear_bit_atomic
> -#define ext3_test_bit ext2_test_bit
> -#define ext3_find_first_zero_bit ext2_find_first_zero_bit
> -#define ext3_find_next_zero_bit ext2_find_next_zero_bit
> +#define ext3_test_bit(nr, addr) \
> + test_le_bit((nr), (unsigned long *)(addr))
> +#define ext3_find_first_zero_bit(addr, size) \
> + find_first_zero_le_bit((unsigned long *)(addr), (size))
> +#define ext3_find_next_zero_bit(addr, size, off) \
> + find_next_zero_le_bit((unsigned long *)(addr), (size), (off))
>
> /*
> * Maximal mount counts between two filesystem checks
> --
> 1.7.1.231.gd0b16
>
--
Jan Kara <jack@xxxxxxx>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/