Re: [PATCH] ARM: allow, but warn, when issuing ioremap() on RAM

From: Benjamin Herrenschmidt
Date: Fri Oct 15 2010 - 22:40:23 EST


On Fri, 2010-10-08 at 17:00 -0700, Greg KH wrote:
>
> But you can't expect that you make this change, and not fix up the
> drivers, and people would be happy, right? The rule for API changes
> like this, or anything, is that the person making the change fixes the
> other drivers, and that seems to be the issue here.
>
> Any pointers to patches where people have fixed up the drivers?

Greg, this is true for normal API changes. In this case, this is silent
data corruption, I think Russell is absolutely right. That exact same
issues have been giving me nightmares on powerpc, mostly due to
(fortunately extremely rare) broken chipsets doing non coherent DMA on
processors that do not allow you architecturally to double map memory
with different attributes.

Cheers,
Ben.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/