Re: [PATCH 5/5] pci: Add support for polling PME state on suspended legacy PCI devices

[Rafael J. Wysocki]

On Friday, October 15, 2010, Jesse Barnes wrote:
> On Mon,  4 Oct 2010 14:22:29 -0400
> Matthew Garrett <mjg@xxxxxxxxxx> wrote:
> 
> > Not all hardware vendors hook up the PME line for legacy PCI devices,
> > meaning that wakeup events get lost. The only way around this is to poll
> > the devices to see if their state has changed, so add support for doing
> > that on legacy PCI devices that aren't part of the core chipset.
> > 
> > Signed-off-by: Matthew Garrett <mjg@xxxxxxxxxx>
> > ---
> >  drivers/pci/pci.c |   77 +++++++++++++++++++++++++++++++++++++++++++++++++++++
> >  1 files changed, 77 insertions(+), 0 deletions(-)
> 
> Yuck, polling.  But I guess we don't have an alternative short of
> rewiring all the cheap platforms out there!
> 
> So, applied.

Actually, the next step should be to avoid polling for the devices that
do signal wakeup normally.  That is, if wakeup interrupts or notifications are
coming for the device, we'll drop it from the list.  This looks doable.

Thanks,
Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/