Re: [PATCH v2.6.36-rc7] oprofile: don't use flush_scheduled_work()

[Tejun Heo]

On 10/15/2010 03:51 PM, Tejun Heo wrote:
> flush_scheduled_work() is deprecated and scheduled to be removed.
> sync_stop() currently cancels cpu_buffer works inside buffer_mutex and
> flushes the system workqueue outside.  Instead, split end_cpu_work()
> into two parts - stopping further work enqueues and flushing works -
> and do the former inside buffer_mutex and latter outside.
> 
> Signed-off-by: Tejun Heo <tj@xxxxxxxxxx>

Ooh, BTW, the global symbols in cpu_buffer seem a bit too generic.  I
don't think oprofile should be defining alloc/free_cpu_buffers() and
start/end/flush_cpu_work().  Maybe it would be a good idea to add op_
prefix to them?

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/