Re: [PATCH 2/5] tcm: Unify INQUIRY subsystem plugin handling

[Nicholas A. Bellinger]

On Thu, 2010-10-14 at 11:26 +0200, Christoph Hellwig wrote:
> On Wed, Oct 13, 2010 at 09:35:37PM -0700, Nicholas A. Bellinger wrote:
> > So you would rather have struct se_device attributes set in TCM
> > subsystem specific ->create_virtdevice() code directly after
> > transport_add_device_to_core_hba() -> se_dev_set_default_attribs(),
> > right..?
> 
> Actually you would want to set them before
> transport_add_device_to_core_hba.  Always make sure an object is fully
> set up before making it accessible.
> 

Hmmmm, very good point.

It would make the most sense to just go ahead and set a pre-configured
struct queue_limits into transport_add_device_to_core_hba() from
subsystem specific ->create_virtdevice() code, and just drop whatever
unnecessary struct se_subsystem_api ops are duplicate of what is being
registered as defaults with struct queue_limits.



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/