Re: Results of my work on memorystick subsystem

[Alex Dubov]

> From: Maxim Levitsky <maximlevitsky@xxxxxxxxx>
> 
> and patch #6 contines adds even more cleanups, and makes
> whole
> memctick subsystem look nice and clean.
> Many non obivous functions were removen.

Replacing functional state handlers with nasty 3-page long switches on
undiscriminated integer state variables does not count either "cleaner"
nor "more obvious" in my notebook.

This is a matter of personal preference, I suppose.

Yet, at the very least, you should define an appropriate enum and give
your states readable names.



      
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/