Re: [RFC PATCH net-next] drivers/net Documentation/networking:Create directory intel_wired_lan

From: Joe Perches
Date: Thu Oct 14 2010 - 01:57:48 EST


On Wed, 2010-10-13 at 21:57 -0700, Jeff Kirsher wrote:
> On Wed, 2010-10-13 at 15:28 -0700, Joe Perches wrote:
> Sorry I am not ignoring you, I was taking a closer look at your patch.
> > What regression testing would actually be done?
> The Makefile and Kconfig needs more work. I applied your patch and none
> of the Intel Wired drivers build.

Care to describe the Makefile/Kconfig issues you have seen?

I built it allyesconfig, defconfig, allmodconfig and allnoconfig.

Perhaps you need to use "git am foo" in a test branch instead
of "patch -p1 < foo" ?

> I am working on providing an updated RFC patch to resolve the
> Makefile/Kconfig issues I found and few other minor issues I have
> found.

Oh good.

cheers, Joe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/