Re: [PATCH -next] edac/mce_amd: fix shift warning

[Borislav Petkov]

From: Randy Dunlap <randy.dunlap@xxxxxxxxxx>
Date: Wed, Oct 13, 2010 at 04:10:57PM -0400

> The BIT() macro works on unsigned longs, but this warning happens
> on i386 (X86_32), where UL is 32 bits and this value needs to be
> 64 bits, so use open-coded ULL.
> 
> drivers/edac/mce_amd.c:262: warning: left shift count >= width of type

Ok, so BIT() should be fixed to work with the largest type available,
IMHO. Let me cook up something.

> Signed-off-by: Randy Dunlap <randy.dunlap@xxxxxxxxxx>
> Cc: Doug Thompson <dougthompson@xxxxxxxxxxxx>
> Cc: Borislav Petkov <borislav.petkov@xxxxxxx>

In the meantime, I'll push your fix to Linus, thanks for testing this on
32-bit :).

-- 
Regards/Gruss,
Boris.

Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/