Re: [GIT PULL] SCSI bug fixes for 2.6.36-rc7

[Harvey Harrison]

On Wed, Oct 13, 2010 at 5:24 PM, James Bottomley
<James.Bottomley@xxxxxxx> wrote:
> On Wed, 2010-10-13 at 16:49 -0700, Linus Torvalds wrote:
>> On Wed, Oct 13, 2010 at 6:45 AM, James Bottomley
>> <James.Bottomley@xxxxxxx> wrote:

>>
>> Umm. That other patch seems to be utter crap.
>>
>> > - Â Â Â hdr->device_status = status_byte(rq->errors);
>> > + Â Â Â hdr->device_status = rq->errors && 0xff;
>>
>> That's pure shit. Please look at it for one second, and don't send me
>> crap like this.
>
> What's wrong with it? device_status() is an ancient SCSI-1 macro that
> dates from the time the status was left shifted by 1, which makes the
> value wrong according to the sg interface spec. ÂWe should really remove
> it, but there's still a few ancient drivers using it. Âthe SG interface
> requires the full status byte, which is what the bottom most byte of
> req_errors is ... hence the change.
>

How about & instead of &&

Harvey
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/