Re: [PATCH 1/6] hid: egalax: Use kzalloc

[Chase Douglas]

On Wed, 2010-10-13 at 15:58 +0200, Henrik Rydberg wrote:
> To avoid unnecessary explicit initialization, allocate zeroed memory.
> 
> Signed-off-by: Henrik Rydberg <rydberg@xxxxxxxxxxx>
> ---
>  drivers/hid/hid-egalax.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/hid/hid-egalax.c b/drivers/hid/hid-egalax.c
> index 54b017a..5a1b52e 100644
> --- a/drivers/hid/hid-egalax.c
> +++ b/drivers/hid/hid-egalax.c
> @@ -221,7 +221,7 @@ static int egalax_probe(struct hid_device *hdev, const struct hid_device_id *id)
>  	struct egalax_data *td;
>  	struct hid_report *report;
>  
> -	td = kmalloc(sizeof(struct egalax_data), GFP_KERNEL);
> +	td = kzalloc(sizeof(struct egalax_data), GFP_KERNEL);
>  	if (!td) {
>  		dev_err(&hdev->dev, "cannot allocate eGalax data\n");
>  		return -ENOMEM;

Pretty obvious.

Acked-by: Chase Douglas <chase.douglas@xxxxxxxxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/