Re: [PATCH] mmc: append a file to change host clock at run time

[Andy Shevchenko]

On Wed, Oct 13, 2010 at 11:07 AM, Adrian Hunter <adrian.hunter@xxxxxxxxx> wrote:
>> +static int mmc_clock_opt_set(void *data, u64 val)
>> +{
>> + Â Â Â struct mmc_host *host = data;
>> +
>> + Â Â Â /* We need this check due to input value is u64 */
>> + Â Â Â if (val> Âhost->f_max)
>> + Â Â Â Â Â Â Â return -EINVAL;
>> +
>> + Â Â Â mmc_set_clock(host, (unsigned int) val);
>
> Probably need to claim the host here otherwise you might
> be changing the clock while a request is in progress
Yeah, good catch. Will fix. Thanks.

-- 
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/