Re: [tip:irq/core] x86: Sanitize apb timer interrupt handling

From: Thomas Gleixner
Date: Tue Oct 12 2010 - 17:28:52 EST


On Tue, 12 Oct 2010, Jacob Pan wrote:

>
> >x86: Sanitize apb timer interrupt handling
> >
> >Disable the interrupt in CPU_DEAD where it belongs.
> My main concern is the performance cost. The power management code for
> Moorestown system make use of the cpu hotplug code (disable_nonboot_cpus)
> but much more frequently. The system low power states are call S0 idle
> state (s0ix).
>
> Leaving the irq enabled at the chip and desc level between S0ix states
> might give some performance benefit. That was my original thought.
> Will it cause problems?

Errm. I merily moved it to the place where it should be. You do the
disable/enable dance already today.

Thanks,

tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/