Re: [PATCH] ath5k: fix build break from "ath5k: Print out opmode in debugfs"

From: Linus Torvalds
Date: Tue Oct 12 2010 - 14:14:31 EST


On Tue, Oct 12, 2010 at 7:53 AM, John W. Linville
<linville@xxxxxxxxxxxxx> wrote:
>
> Please don't make me commit such an ugly patch...

 Why don't you just create a dummy inline ath_opmode_to_string() that
returns NULL in the non-debug case? The compiler will make the
conditionals all go away, and it will end up being "UNKNOWN" which is
just what you want. No?

Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/