Re: [PATCH] sched: drop all load weight manipulation for RT tasks

From: Peter Zijlstra
Date: Tue Oct 12 2010 - 05:31:44 EST


On Mon, 2010-10-11 at 16:36 +0200, Linus Walleij wrote:
> Load weights are for the CFS, they do not belong in the RT
> task. This makes all RT scheduling classes leave the
> CFS weights alone.
>
> This fixes a real bug as well: I noticed the following
> phonomena: a process elevated to SCHED_RR forks with
> SCHED_RESET_ON_FORK set, and the child is indeed SCHED_OTHER,
> and the niceval is indeed reset to 0. However the
> weight inserted by set_load_weight() remains at 0. giving the
> task insignificat priority.
>
> With this fix, the weight is reset to what the task had before
> being elevated to SCHED_RR/SCHED_FIFO.
>
> Cc: Lennart Poettering <lennart@xxxxxxxxxxxxxx>
> Cc: stable@xxxxxxxxxx
> Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxxxxxx>

Thanks, queued it up, we'll see if anything explodes ;-)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/