Re: RFC: Implement hwpoison on free for soft offlining

[KOSAKI Motohiro]

> Andi Kleen <andi@xxxxxxxxxxxxxx> writes:
> 
> > Here's a somewhat experimental patch to improve soft offlining
> > in hwpoison, but allowing hwpoison on free for not directly
> > freeable page types. It should work for nearly all
> > left over page types that get eventually freed, so this makes
> > soft offlining nearly universal. The only non handleable page
> > types are now pages that never get freed.
> >
> > Drawback: It needs an additional page flag. Cannot set hwpoison
> > directly because that would not be "soft" and cause errors.
> 
> Ping? Any comments on this patch?
> 
> Except for the page flag use I think it's nearly a no brainer. 
> A lot of new soft hwpoison capability for very little additional code.
> 
> Has anyone a problem using up a 64bit page flag for that?

To me, it's no problem if this keep 64bit only. IOW, I only dislike to
add 32bit page flags.

Yeah, memory corruption is very crap and i think your effort has a lot
of worth :)


offtopic, I don't think CONFIG_MEMORY_FAILURE and CONFIG_HWPOISON_ON_FREE
are symmetric nor easy understandable. can you please consider naming change?
(example, CONFIG_HWPOISON/CONFIG_HWPOISON_ON_FREE, 
CONFIG_MEMORY_FAILURE/CONFIG_MEMORY_FAILURE_SOFT_OFFLINE)



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/