Re: [PATCH v2] memcg: reduce lock time at move charge (Was Re:[PATCH 04/10] memcg: disable local interrupts in lock_page_cgroup()

[Daisuke Nishimura]

> +err_out:
> +	for (; mt < info + num; mt++)
> +		if (mt->type == MC_TARGET_PAGE) {
> +			putback_lru_page(mt->val.page);
Is this putback_lru_page() necessary ?
is_target_pte_for_mc() doesn't isolate the page.

Thanks,
Daisuke Nishimura.


> +			put_page(mt->val.page);
> +		}
> +	goto out;
>  }
>  
>  static void mem_cgroup_move_charge(struct mm_struct *mm)
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/