Re: [PATCH] x86, setup: Check early serial console per string insteadof one char

[H. Peter Anvin]

On 10/11/2010 12:47 PM, Yinghai Lu wrote:
>>
>> This seems to add a bunch of code for zero benefit.  Testing a global
>> variable is zero cost compared to either a BIOS call or poking a serial
>> port.
> 
> some server have bios serial console redirection support, and bios int call could send char to screen and serial port.
> 
> in that case, take out serial_putchar from putchar could produce more readable print out from serial console
> 

That doesn't appear to have anything to do with this code change.  What
you're saying is that "if BIOS does serial console redirection, we
shouldn't output to both the serial console and the BIOS console", which
is of course a truism, but that doesn't justify in any way this
particular code reconfiguration.

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/