Re: [PATCH] x86, setup: Check early serial console per string insteadof one char

[H. Peter Anvin]

On 10/11/2010 10:50 AM, Yinghai Lu wrote:
> 
> Move out serial_putchar() calling out of putchar
> Let puts() to call serial_putchar() directly.
> 
> So only need to check early_serial_base per string.
> 
> Signed-off-by: Yinghai Lu <yinghai@xxxxxxxxxx>
> 

This seems to add a bunch of code for zero benefit.  Testing a global
variable is zero cost compared to either a BIOS call or poking a serial
port.

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/