Re: [PATCH] ARM: allow, but warn, when issuing ioremap() on RAM

From: Greg KH
Date: Fri Oct 08 2010 - 20:53:45 EST


On Sat, Oct 09, 2010 at 01:25:47AM +0100, Russell King - ARM Linux wrote:
> On Fri, Oct 08, 2010 at 05:00:46PM -0700, Greg KH wrote:
> > But you can't expect that you make this change, and not fix up the
> > drivers, and people would be happy, right? The rule for API changes
> > like this, or anything, is that the person making the change fixes the
> > other drivers, and that seems to be the issue here.
>
> Let's entirely revert the change and wait for people's data to be
> corrupted then. I don't have the time nor the motivation to work
> through crap driver code to fix up these unreliable games which are
> already illegal on platforms such as x86.
>
> If people want their system to be unpredictable, then let's carry on
> giving them the rope to hang themselves in that manner.
>
> > Any pointers to patches where people have fixed up the drivers?
>
> Despite the discussion, I'm unaware of anyone really taking the issue
> seriously and producing any patches during the last six months.
>
> So, I say sod it, let's revert the change.

Well, how about throw a big WARN() to let people know that their driver
needs to be fixed? That will give them the chance, right?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/