Re: [PATCH 07/17] Make dentry::d_mounted into a more general field for special function dirs

From: Valerie Aurora
Date: Fri Oct 08 2010 - 19:58:18 EST


On Thu, Sep 30, 2010 at 07:15:31PM +0100, David Howells wrote:
> Make the d_mounted field in struct dentry into a more general field for special
> function directories such as mountpoints and autofs substructures.
>
> d_mounted is renamed d_managed, and that is split into three fields:
>
> (*) #define DMANAGED_MOUNTPOINT 0x0fffffff

No matter how hard I try, I always read this as "DAMAGED". Which I
can't help but imagine subliminally influences the reader's opinion of
the patches.

Of course I am excellent at naming things, see "chunkfs" and
"relatime". But some ideas for naming various concepts in this patch:

D_MIGHT_MOUNT
D_CHILL_OUT
D_ITS_COMPLICATED

-VAL
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/