Re: Linux 2.6.36-rc7

[Andreas Gruenbacher]

On Friday 08 October 2010 18:38:28 Eric Paris wrote:
> However, THIS is potentially a real ABI problem and something which
> deals with the interface.  Alan seemed to lean towards pulling the
> syscalls. It is relatively easily solved without changing the interface
> or breaking userspace in 2.6.37.  We use some set of the flags bits as a
> priority (we only use 2 of the 32 bits today so we have plenty) and
> order groups with highest priority first, 0 priority last, and 2+ groups
> with the same priority have unpredictable ordering.  I'd then call
> priorities other than 0 a 2.6.37 feature.  If we do it in flags I think
> that leaves us with say 8 bits and thus 255 priorities.

That's a possibility but it seems quite messy for a brand new system call.  
I'd still pull the system call and work out the few remaining quirkses.

Thanks.

> ------
> 
> I said I wouldn't refute your claims but I can't help myself on one
> account which I think might mislead people.
> 
>  * Some weaknesses in the interface design were only identified and fixed
>    late in the -rc phase, changing the ABI.  There may be more issues, like
>    the priority discussion.  This might leave us with a broken ABI we would
>    need to support forever.
> 
> Between rc2 and rc3 we switched the order and size of a couple of fields
> to help alignment, it did break ABI, but it wasn't an interface failing.
> See: 0fb85621df4f.

See, a weakness, not a failure.  What I said.

The main issue that Andreas Schwab has pointed out (and which also lead to 
this commit) was the packing of the structs which leads to inefficient code, 
though.  This hasn't been fixed but it still can be, in a backwards compatible 
way.

Thanks,
Andreas
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/