Re: [RFC/PATCH v3] usb: usb3.0 ch9 definitions

[Matthew Wilcox]

On Fri, Oct 08, 2010 at 05:35:40AM -0700, Brokhman Tatyana wrote:
> >> + */
> >> +#define USB_DEVICE_U1_ENABLE	48	/* dev may initiate U1 transition */
> >> +#define USB_DEVICE_U2_ENABLE	49	/* dev may initiate U2 transition*/
> >> +#define USB_DEVICE_LTM_ENABLE	50	/* dev may send LTM*/
> >> +#define USB_INTRF_FUNC_SUSPEND	0	/* function suspend*/

Missing space before the '*/' on these three lines.

> > __le16?  I'm guessing these fields haven't actually been used for
> > anything?
> 
> Actually __bU2DevExitLat is not bitwise field so it can remain __u16. And
> no, their values have been used for nothing but testing the descriptor.

The __le16 isn't about bitfields.  It's about the fact that the bytes
are stored in little-endian form.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/