Re: Peculiar stuff in hci_ath3k/badness in hci_uart

From: Suraj Sumangala
Date: Fri Oct 08 2010 - 05:18:12 EST


Hi Alan,

On 10/8/2010 2:11 AM, Alan Cox wrote:
Noticed this while looking at Savoy's stuff


ath_wakeup_ar3k:

int status = tty->driver->ops->tiocmget(tty, NULL);

I agree, it will be a problem if the underlying driver try to access the "struct file". Is there any other way I can get the MCR status here without providing user space pointer?


Fortunately I looked further and the further I looked the more fun it gets

in hci_uart we have

len = tty->ops->write(tty, skb->data, skb->len);

Regards
Suraj
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/