Re: [PATCH 1/2] drivers:bluetooth: TI_ST bluetooth driver

[Greg KH]

On Thu, Oct 07, 2010 at 04:09:06PM -0300, Gustavo F. Padovan wrote:
> * Greg KH <greg@xxxxxxxxx> [2010-10-07 14:30:18 -0700]:
> 
> > On Thu, Oct 07, 2010 at 02:51:48PM -0300, Gustavo F. Padovan wrote:
> > > Hi Greg,
> > > 
> > > * Greg KH <greg@xxxxxxxxx> [2010-10-07 07:34:09 -0700]:
> > > 
> > > > On Thu, Oct 07, 2010 at 12:05:48PM +0200, Marcel Holtmann wrote:
> > > > > Hi Pavan,
> > > > > 
> > > > > > This is the bluetooth protocol driver for the TI WiLink7 chipsets.
> > > > > > Texas Instrument's WiLink chipsets combine wireless technologies
> > > > > > like BT, FM, GPS and WLAN onto a single chip.
> > > > > > 
> > > > > > This Bluetooth driver works on top of the TI_ST shared transport
> > > > > > line discipline driver which also allows other drivers like
> > > > > > FM V4L2 and GPS character driver to make use of the same UART interface.
> > > > > > 
> > > > > > Signed-off-by: Pavan Savoy <pavan_savoy@xxxxxx>
> > > > > > ---
> > > > > >  drivers/bluetooth/bt_ti.c      |  463 ++++++++++++++++++++++++++++++++++++
> > > > > >  drivers/staging/ti-st/bt_drv.c |  509 ----------------------------------------
> > > > > >  drivers/staging/ti-st/bt_drv.h |   61 -----
> > > > > >  3 files changed, 463 insertions(+), 570 deletions(-)
> > > > > >  create mode 100644 drivers/bluetooth/bt_ti.c
> > > > > >  delete mode 100644 drivers/staging/ti-st/bt_drv.c
> > > > > >  delete mode 100644 drivers/staging/ti-st/bt_drv.h
> > > > > 
> > > > > I don't care about staging at all. So you sort that out with Greg.
> > > > > 
> > > > > Submit your driver for upstream inclusion. And once accepted you can pin
> > > > > Greg about removing it.
> > > > 
> > > > The driver is already in staging, this is the request to move it out of
> > > > staging and into the "correct" place in the tree.  The core of the ti-st
> > > > code is now in the drivers/misc/ directory in the linux-next tree, and
> > > > this patch is the request to move the bluetooth drive into the proper
> > > > drivers/bluetooth/ location.
> > > 
> > > I'm wondering why this driver never touched linux-bluetooth before. It
> > > is on staging because it is not ready for a proper merge and while it is
> > > not ready it needs the comments from the bluetooth developers here to
> > > get it ready for merge in drivers/bluetooth. So why this never arrived 
> > > here before?
> > 
> > This is the exact reason _why_ it is being sent here now.  To get the
> > review of the bluetooth developers for any changes that are needed to
> > get it merged into the proper place in the tree.
> 
> Yes, but IMHO it took to long, from what I looked this drivers was merged
> in stage about May and the patches arrived in linux-bluetooth only in
> October. Is there a reason for such delay?

It took that long to get the "obvious" things fixed up.

> That's is something we need to fix for the next bluetooth drivers we
> want to merge, so the developers can get feedback earlier.

If you want to be notified of staging drivers that affect the bluetooth
stuff earlier, fine, I'll let you know.  Otherwise, no other subsystem
has asked for such notification, preferring to let the stable stuff stay
alone in the directory until it at least achieves a basic "clean" level.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/