Re: [RFC v2 PATCH 1/1] PCI: override BIOS/firmware resourceallocation

From: Ram Pai
Date: Wed Oct 06 2010 - 20:30:55 EST


On Wed, Oct 06, 2010 at 05:39:53PM -0600, Bjorn Helgaas wrote:
> On Wed, Oct 06, 2010 at 03:58:34PM -0700, Ram Pai wrote:
> > PCI: override BIOS/firmware memory resource allocation
> > through command line parameters
> >
> > Platforms that are unaware of SRIOV BARs fail to allocate MMIO
> > resources to SRIOV PCIe devices. Hence on such platforms the
> > OS fails to enable SRIOV.
> > Some platforms where BIOS/uEFI resource allocations conflict
> > the conflicting devices are disabled.
> >
> > Ideally we would want the OS to detect and fix automatically
> > such problems and conflicts. However previous attempts to do so
> > have led to regression on legacy platforms.
>
> I'm sorry to be a nay-sayer, but I think we just haven't tried hard
> enough. Our ACPI/PCI/e820 resource management is not well integrated,
> and I suspect if we straightened that out, we could avoid some of the
> regressions we saw with previous attempts.

Can you be more specific as to what can be done to fix it automatically?

Neither accepting this approach nor telling what needs to be straightened out
to automatically fix all the systems out there, is just a deadend.

The choice is between
(a) an automated patch with the risk of regressing some platforms.
(b) an semi-automated patch that does not regress *any* platform,
with the ability to fix platforms that are currently broken.
(c) status quo, which means broken platforms continue to be so.

I thought the initial proposal was to use (b), with the long
term goal of fixing it automatically, assuming that it is even possible.

Let me know if that is *not* the goal and I will change directions.
RP
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/