Re: [PATCH 07/28] Staging: comedi: drivers.c: Edit file so that checkpatch.plhas 4 warnings and 0 errors

[David Daney]

On 10/05/2010 06:00 PM, Tracey Dent wrote:
> Changed a few lines that made checkpatch.pl complain. Could not get ever warning but
> I got it down to to just 4, WARNING: line over 80 characters.

The overall goal is to improve the code, not placate checkpatch.pl

[...]
>   				printk
> -				    (KERN_WARNING "BUG! detaching device with use_count=%d\n",
> -				     dev->use_count);
> +				    (KERN_WARNING "BUG! detaching device     \
> +							with use_count=%d\n",
> +							dev->use_count);

Is that really an improvement?

And even if it were, is that really how strings should be split up?

Hint:
	pr_warning("BUG! detaching device with use_count=%d\n",
		   dev->use_count);


David Daney
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/