Re: [PATCH] iwlwifi: fix iwlwifi scanning corner cases

[Stanislaw Gruszka]

Hi Florian

On Wed, Oct 06, 2010 at 12:21:32AM +0200, Florian Mickler wrote:
> Stanislaw Gruszka pointed out, that commit
> "iwl3945: queue the right work if the scan needs to be aborted"
> has an awkward definition of "right". Specifically the abort_scan work
> doesn't notify the generic wireless stack that the scan was aborted.
> 
> In order to get rid of the warning in bug
> https://bugzilla.kernel.org/show_bug.cgi?id=17722
> we inform ieee80211_scan_completed that we are aborting
> the scan by setting the apropriate status bit in request_scan and 
> pass it into ieee80211_scan_completed. 
> 
> Signed-off-by: Florian Mickler <florian@xxxxxxxxxxx>
> ---
> 
> Hi John!
> 
> Here is the fix that Stanislaw described. 
> (Yes, it is in a brown paper bag.)  Please wait for him to review this. 
> 
> Another option would be to just revert my previous patch and live with the 
> warning until the scanning rework hit's mainline.

This patch is not so bad, but better would be just return value from 
{iwlagn,iwl3945}_request_scan instead of queuing anything. I will
prepare patch(s) today or tomorrow.

Stanislaw
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/