Re: [PATCH 00/10] memcg: per cgroup dirty page accounting

[Ciju Rajan K]

Greg Thelen wrote:
> Balbir Singh <balbir@xxxxxxxxxxxxxxxxxx> writes:
>   
> > * Greg Thelen <gthelen@xxxxxxxxxx> [2010-10-03 23:57:55]:
> >
> >     
> > > This patch set provides the ability for each cgroup to have independent dirty
> > > page limits.
> > >
> > > Limiting dirty memory is like fixing the max amount of dirty (hard to reclaim)
> > > page cache used by a cgroup.  So, in case of multiple cgroup writers, they will
> > > not be able to consume more than their designated share of dirty pages and will
> > > be forced to perform write-out if they cross that limit.
> > >
> > > These patches were developed and tested on mmotm 2010-09-28-16-13.  The patches
> > > are based on a series proposed by Andrea Righi in Mar 2010.
> > >       
> > Hi, Greg,
> >
> > I see a problem with "    memcg: add dirty page accounting infrastructure".
> >
> > The reject is
> >
> >  enum mem_cgroup_write_page_stat_item {
> >         MEMCG_NR_FILE_MAPPED, /* # of pages charged as file rss */
> > +       MEMCG_NR_FILE_DIRTY, /* # of dirty pages in page cache */
> > +       MEMCG_NR_FILE_WRITEBACK, /* # of pages under writeback */
> > +       MEMCG_NR_FILE_UNSTABLE_NFS, /* # of NFS unstable pages */
> >  };
> >
> > I don't see mem_cgroup_write_page_stat_item in memcontrol.h. Is this
> > based on top of Kame's cleanup.
> >
> > I am working off of mmotm 28 sept 2010 16:13.
> >     
>
> Balbir,
>
> All of the 10 memcg dirty limits patches should apply directly to mmotm
> 28 sept 2010 16:13 without any other patches.  Any of Kame's cleanup
> patches that are not in mmotm are not needed by this memcg dirty limit
> series.
>
> The patch you refer to, "[PATCH 05/10] memcg: add dirty page accounting
> infrastructure" depends on a change from an earlier patch in the series.
> Specifically, "[PATCH 03/10] memcg: create extensible page stat update
> routines" contains the addition of mem_cgroup_write_page_stat_item:
>
> --- a/include/linux/memcontrol.h
> +++ b/include/linux/memcontrol.h
> @@ -25,6 +25,11 @@ struct page_cgroup;
>  struct page;
>  struct mm_struct;
>
> +/* Stats that can be updated by kernel. */
> +enum mem_cgroup_write_page_stat_item {
> +     MEMCG_NR_FILE_MAPPED, /* # of pages charged as file rss */
> +};
> +
>
> Do you have trouble applying patch 5 after applying patches 1-4?
>   
I could apply all the patches cleanly on mmotm 28/09/2010. Kernel build 
also went through.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>
>   

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/