Re: Dynamic nop selection breaks boot on Geode LX

From: Jason Baron
Date: Mon Oct 04 2010 - 16:39:59 EST


On Mon, Oct 04, 2010 at 04:31:12PM -0400, Steven Rostedt wrote:
> On Mon, 2010-10-04 at 11:46 -0400, Jason Baron wrote:
>
> > restart_nmi();
> > +
> > + local_irq_save(flags);
> > + arch_init_ideal_nop5();
> > + local_irq_restore(flags);
> > }
> >
> > /**
>
> BTW, why the irq disabling around the call?
>
> -- Steve
>
>

Only b/c the selection of the nop was originally done by
'ftrace_dyn_arch_init()' which had irq's disabled around it. So maybe
that can be dropped now?

thanks,

-Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/